Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin xarray #47016

Merged
merged 3 commits into from
May 16, 2022
Merged

Unpin xarray #47016

merged 3 commits into from
May 16, 2022

Conversation

djgray780
Copy link
Contributor

@djgray780 djgray780 changed the title CI: unpin xarray Unpin xarray May 13, 2022
@djgray780 djgray780 mentioned this pull request May 13, 2022
Closed
MarcoGorelli
MarcoGorelli requested changes May 14, 2022
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this is breaking a doctest example

FAILED pandas/core/generic.py::pandas.core.generic.NDFrame.to_xarray

https://github.com/pandas-dev/pandas/runs/6429906335?check_suite_focus=true

@jreback jreback added the Dependencies Required and optional dependencies label May 15, 2022
@simonjayhawkins
Copy link
Member

looks like this is breaking a doctest example

xref #42716 (comment) for the doctest issue (the mypy part seems fine now)

@djgray780
Copy link
Contributor Author

djgray780 commented May 16, 2022 •
edited
Loading

It seems that the CircleCI: test-arm is not passing. Upon inspecting the error, it seems there might be a numpy dependency missing. I think that the previous doctest issue is fixed now, but will check back in the morning.

MarcoGorelli
MarcoGorelli approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

The test-arm failure looks unrelated, might be worth fetching and merging upstream/main when it's fixed to check

@simonjayhawkins simonjayhawkins added this to the 1.5 milestone May 16, 2022
@simonjayhawkins simonjayhawkins merged commit 7bf3c75 into pandas-dev:main May 16, 2022
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@djgray780 @yehoshuadimarsky
Unpin xarray (pandas-dev#47016)
cdb0b11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Dependencies Required and optional dependencies
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
4 participants
@djgray780 @simonjayhawkins @MarcoGorelli @jreback